fix(group): require AMPAdmin for well project add/remove#737
Closed
jeremyzilar wants to merge 2 commits into
Closed
fix(group): require AMPAdmin for well project add/remove#737jeremyzilar wants to merge 2 commits into
jeremyzilar wants to merge 2 commits into
Conversation
Well project add/remove is gated to AMP.Admin in the UI, but the API routes checked the legacy Admin group. AMP admins without global Admin got 401 Unauthorized on preview and staging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preview and staging return 401 when AMP admins use the well edit panel to add or remove projects. The UI gates Edit to
AMP.Admin, but the group thing association routes required the legacy globalAdminJWT group.Changes
POST/DELETE /group/{group_id}/things/{thing_id}to useamp_admin_dependencyinstead ofadmin_dependency.Test plan
uv run pytest tests/test_group.py -k thing_to_group -qAMP.Adminuser without globalAdmin, add a project on a well preview branch and confirm successAMPAdminstill cannot call the routes